Re: [PATCH 57/57] target/arm: Convert SQDMULH, SQRDMULH to decodetree

[Richard Henderson]

On 5/21/24 09:16, Peter Maydell wrote:
> > +void HELPER(neon_sqrdmulh_idx_s)(void *vd, void *vn, void *vm,
> > +                                 void *vq, uint32_t desc)
> > +{
> > +    intptr_t i, j, opr_sz = simd_oprsz(desc);
> > +    int idx = simd_data(desc);
> > +    int32_t *d = vd, *n = vn, *m = (int32_t *)vm + H4(idx);
> > +
> > +    for (i = 0; i < opr_sz / 4; i += 16 / 4) {
> > +        int16_t mm = m[i];
>
> Wrong type -- this is the 's' version so should be int32_t,
> I think.

Oops, yes.


r~