Re: [PATCH v2 2/4] audio: Depend on dbus_display1_dep

[Marc-André Lureau]

Hi

On Fri, Dec 15, 2023 at 3:29 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> dbusaudio needs dbus_display1_dep.
>
> Fixes: 739362d4205c ("audio: add "dbus" audio backend")

The build didn't fail, did it? You don't need to backport this, thus I
don't think "Fixes" apply here.

(furthermore, dbus_display1_dep was added later, in commit 1222070e7
"meson: ensure dbus-display generated code is built before other
units")

> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

otherwise, lgtm
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  audio/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/audio/meson.build b/audio/meson.build
> index c8f658611f42..608f35e6af78 100644
> --- a/audio/meson.build
> +++ b/audio/meson.build
> @@ -30,7 +30,8 @@ endforeach
>
>  if dbus_display
>      module_ss = ss.source_set()
> -    module_ss.add(when: [gio, pixman], if_true: files('dbusaudio.c'))
> +    module_ss.add(when: [gio, dbus_display1_dep, pixman],
> +                  if_true: files('dbusaudio.c'))
>      audio_modules += {'dbus': module_ss}
>  endif
>
>
> --
> 2.43.0
>
>


-- 
Marc-André Lureau