[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] meson: Explicitly specify dbus-display1.h dependency
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH v2 3/4] meson: Explicitly specify dbus-display1.h dependency |
Date: |
Fri, 15 Dec 2023 16:05:32 +0400 |
Hi
On Fri, Dec 15, 2023 at 3:29 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Explicitly specify dbus-display1.h as a dependency so that files
> depending on it will not get compiled too early.
>
> Fixes: 1222070e7728 ("meson: ensure dbus-display generated code is built
> before other units")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
ok, hopefully this finally fixes the problem.. I have the feeling the
solution applied in this commit isn't the right one..
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 5e1b25a47184..c31168e11cfb 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2032,7 +2032,7 @@ if dbus_display
> '--c-namespace', 'QemuDBus',
> '--generate-c-code', '@BASENAME@'])
> dbus_display1_lib = static_library('dbus-display1', dbus_display1,
> dependencies: gio)
> - dbus_display1_dep = declare_dependency(link_with: dbus_display1_lib,
> include_directories: include_directories('.'))
> + dbus_display1_dep = declare_dependency(link_with: dbus_display1_lib,
> sources: dbus_display1[0])
> endif
>
> have_virtfs = get_option('virtfs') \
>
> --
> 2.43.0
>
>
--
Marc-André Lureau