[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 16/17] async: Suppress GCC13 false positive in aio_bh_poll()
From: |
Paolo Bonzini |
Subject: |
[PULL 16/17] async: Suppress GCC13 false positive in aio_bh_poll() |
Date: |
Sat, 29 Apr 2023 14:16:35 +0200 |
From: Cédric Le Goater <clg@redhat.com>
GCC13 reports an error :
../util/async.c: In function ‘aio_bh_poll’:
include/qemu/queue.h:303:22: error: storing the address of local variable
‘slice’ in ‘*ctx.bh_slice_list.sqh_last’ [-Werror=dangling-pointer=]
303 | (head)->sqh_last = &(elm)->field.sqe_next;
\
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
../util/async.c:169:5: note: in expansion of macro ‘QSIMPLEQ_INSERT_TAIL’
169 | QSIMPLEQ_INSERT_TAIL(&ctx->bh_slice_list, &slice, next);
| ^~~~~~~~~~~~~~~~~~~~
../util/async.c:161:17: note: ‘slice’ declared here
161 | BHListSlice slice;
| ^~~~~
../util/async.c:161:17: note: ‘ctx’ declared here
But the local variable 'slice' is removed from the global context list
in following loop of the same routine. Add a pragma to silent GCC.
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20230420202939.1982044-1-clg@kaod.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/async.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/util/async.c b/util/async.c
index 21016a1ac7c1..856e1a8a337a 100644
--- a/util/async.c
+++ b/util/async.c
@@ -164,7 +164,21 @@ int aio_bh_poll(AioContext *ctx)
/* Synchronizes with QSLIST_INSERT_HEAD_ATOMIC in aio_bh_enqueue(). */
QSLIST_MOVE_ATOMIC(&slice.bh_list, &ctx->bh_list);
+
+ /*
+ * GCC13 [-Werror=dangling-pointer=] complains that the local variable
+ * 'slice' is being stored in the global 'ctx->bh_slice_list' but the
+ * list is emptied before this function returns.
+ */
+#if !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wpragmas"
+#pragma GCC diagnostic ignored "-Wdangling-pointer="
+#endif
QSIMPLEQ_INSERT_TAIL(&ctx->bh_slice_list, &slice, next);
+#if !defined(__clang__)
+#pragma GCC diagnostic pop
+#endif
while ((s = QSIMPLEQ_FIRST(&ctx->bh_slice_list))) {
QEMUBH *bh;
--
2.40.0
- [PULL 04/17] i386/cpu: Update how the EBX register of CPUID 0x8000001F is set, (continued)
- [PULL 04/17] i386/cpu: Update how the EBX register of CPUID 0x8000001F is set, Paolo Bonzini, 2023/04/29
- [PULL 05/17] target/i386: Add support for CMPCCXADD in CPUID enumeration, Paolo Bonzini, 2023/04/29
- [PULL 06/17] target/i386: Add support for AMX-FP16 in CPUID enumeration, Paolo Bonzini, 2023/04/29
- [PULL 07/17] target/i386: Add support for AVX-IFMA in CPUID enumeration, Paolo Bonzini, 2023/04/29
- [PULL 08/17] target/i386: Add support for AVX-VNNI-INT8 in CPUID enumeration, Paolo Bonzini, 2023/04/29
- [PULL 10/17] target/i386: Add support for PREFETCHIT0/1 in CPUID enumeration, Paolo Bonzini, 2023/04/29
- [PULL 09/17] target/i386: Add support for AVX-NE-CONVERT in CPUID enumeration, Paolo Bonzini, 2023/04/29
- [PULL 12/17] update-linux-headers.sh: Add missing kernel headers., Paolo Bonzini, 2023/04/29
- [PULL 13/17] Update linux headers to v6.3rc5, Paolo Bonzini, 2023/04/29
- [PULL 14/17] tests: vhost-user-test: release mutex on protocol violation, Paolo Bonzini, 2023/04/29
- [PULL 16/17] async: Suppress GCC13 false positive in aio_bh_poll(),
Paolo Bonzini <=
- [PULL 11/17] Fix libvhost-user.c compilation., Paolo Bonzini, 2023/04/29
- [PULL 15/17] target/hexagon: fix = vs. == mishap, Paolo Bonzini, 2023/04/29
- [PULL 17/17] cpus-common: stop using mb_set/mb_read, Paolo Bonzini, 2023/04/29