Re: [PATCH v11 01/13] target/arm: Move cortex sysregs into a separate file

[Philippe Mathieu-Daudé]

On 26/4/23 20:00, Fabiano Rosas wrote:
> The file cpu_tcg.c is about to be moved into the tcg/ directory, so
> move the register definitions into a new file.
>
> Also move the function declaration to the more appropriate cpregs.h.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   target/arm/cortex-regs.c | 69 ++++++++++++++++++++++++++++++++++++++++

Worth renaming explicitly as cortex-a_regs.c?

Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   target/arm/cpregs.h      |  6 ++++
>   target/arm/cpu64.c       |  1 +
>   target/arm/cpu_tcg.c     | 59 ----------------------------------
>   target/arm/internals.h   |  6 ----
>   target/arm/meson.build   |  1 +
>   6 files changed, 77 insertions(+), 65 deletions(-)
>   create mode 100644 target/arm/cortex-regs.c