qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 08/13] tests/qtest: Fix tests when no KVM or TCG are pres


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v11 08/13] tests/qtest: Fix tests when no KVM or TCG are present
Date: Fri, 28 Apr 2023 23:32:36 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 26/4/23 20:00, Fabiano Rosas wrote:
It is possible to have a build with both TCG and KVM disabled due to
Xen requiring the i386 and x86_64 binaries to be present in an aarch64
host.

If we build with --disable-tcg on the aarch64 host, we will end-up
with a QEMU binary (x86) that does not support TCG nor KVM.

Skip tests that crash or hang in the above scenario. Do not include
any test cases if TCG and KVM are missing.

Make sure that calls to qtest_has_accel are placed after g_test_init
in similar fashion to commit ae4b01b349 ("tests: Ensure TAP version is
printed before other messages") to avoid TAP parsing errors.

Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
  tests/qtest/bios-tables-test.c | 11 +++++++++--
  tests/qtest/boot-serial-test.c |  5 +++++
  tests/qtest/migration-test.c   |  9 ++++++++-
  tests/qtest/pxe-test.c         |  8 +++++++-
  tests/qtest/vmgenid-test.c     |  9 +++++++--
  5 files changed, 36 insertions(+), 6 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]