Re: [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX sin

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX sin

From:	Richard Henderson
Subject:	Re: [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets
Date:	Fri, 28 Apr 2023 09:09:40 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 4/28/23 00:00, Taylor Simpson wrote:

The generated helpers for HVX use pass-by-reference, so they can't
short-circuit when the reads/writes overlap.  The instructions with
overrides are OK because they use tcg_gen_gvec_*.

We add a flag has_hvx_helper to DisasContext and extend gen_analyze_funcs
to set the flag when the instruction is an HVX instruction with a
generated helper.

We add an override for V6_vcombine so that it can be short-circuited
along with a test case in tests/tcg/hexagon/hvx_misc.c

Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
---


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 02/21] Hexagon (target/hexagon) Add DisasContext arg to gen_log_reg_write, (continued)
- [PATCH v2 02/21] Hexagon (target/hexagon) Add DisasContext arg to gen_log_reg_write, Taylor Simpson, 2023/04/27
- [PATCH v2 05/21] Hexagon (target/hexagon) Add overrides for clr[tf]new, Taylor Simpson, 2023/04/27
  - Re: [PATCH v2 05/21] Hexagon (target/hexagon) Add overrides for clr[tf]new, Richard Henderson, 2023/04/28
- [PATCH v2 04/21] Hexagon (target/hexagon) Add overrides for allocframe/deallocframe, Taylor Simpson, 2023/04/27
- [PATCH v2 12/21] Hexagon (target/hexagon) Short-circuit packet predicate writes, Taylor Simpson, 2023/04/27
- [PATCH v2 03/21] Hexagon (target/hexagon) Add overrides for loop setup instructions, Taylor Simpson, 2023/04/27
- [PATCH v2 07/21] Hexagon (target/hexagon) Eliminate uses of log_pred_write function, Taylor Simpson, 2023/04/27
- [PATCH v2 15/21] Hexagon (target/hexagon) Add overrides for disabled idef-parser insns, Taylor Simpson, 2023/04/27
- [PATCH v2 19/21] Hexagon (target/hexagon) Move pred_written to DisasContext, Taylor Simpson, 2023/04/27
- [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets, Taylor Simpson, 2023/04/27
  - Re: [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets, Richard Henderson <=
- [PATCH v2 09/21] Hexagon (target/hexagon) Don't overlap dest writes with source reads, Taylor Simpson, 2023/04/27
- [PATCH v2 10/21] Hexagon (target/hexagon) Mark registers as read during packet analysis, Taylor Simpson, 2023/04/27
- [PATCH v2 08/21] Hexagon (target/hexagon) Clean up pred_written usage, Taylor Simpson, 2023/04/27
- [PATCH v2 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER, Taylor Simpson, 2023/04/27
  - Re: [PATCH v2 01/21] meson.build Add CONFIG_HEXAGON_IDEF_PARSER, Richard Henderson, 2023/04/28
- [PATCH v2 16/21] Hexagon (target/hexagon) Make special new_value for USR, Taylor Simpson, 2023/04/27
- [PATCH v2 13/21] Hexagon (target/hexagon) Short-circuit packet HVX writes, Taylor Simpson, 2023/04/27
- [PATCH v2 11/21] Hexagon (target/hexagon) Short-circuit packet register writes, Taylor Simpson, 2023/04/27
  - RE: [PATCH v2 11/21] Hexagon (target/hexagon) Short-circuit packet register writes, Brian Cain, 2023/04/27
- [PATCH v2 18/21] Hexagon (target/hexagon) Move new_pred_value to DisasContext, Taylor Simpson, 2023/04/27

Prev by Date: Re: [PATCH v2 05/21] Hexagon (target/hexagon) Add overrides for clr[tf]new
Next by Date: Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues
Previous by thread: [PATCH v2 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets
Next by thread: [PATCH v2 09/21] Hexagon (target/hexagon) Don't overlap dest writes with source reads
Index(es):
- Date
- Thread