Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine cont

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine cont

From:	Paolo Bonzini
Subject:	Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context
Date:	Thu, 27 Apr 2023 22:49:00 +0200

Il gio 27 apr 2023, 19:00 Kevin Wolf <kwolf@redhat.com> ha scritto:

By the way, and slightly unrelated, can vrc somehow help with finding
places that call coroutine wrappers without holding the AioContext lock?
(This results in an abort() when AIO_WAIT_WHILE() tries to unlock the
AioContext.) This is one of the classes of bugs we're seeing in 8.0.

Seems more like a task for TSA.

Even though C TSA doesn't let you check that the *right* AioContext lock is taken, it can check statically that *one* such lock is taken, and in general I would guess it's rare for the wrong AioContext to be locked.

Paolo

Kevin

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 02/20] block: Consistently call bdrv_activate() outside coroutine, (continued)
- [PATCH 02/20] block: Consistently call bdrv_activate() outside coroutine, Kevin Wolf, 2023/04/25
  - Re: [PATCH 02/20] block: Consistently call bdrv_activate() outside coroutine, Eric Blake, 2023/04/25
- [PATCH 04/20] block: Don't call no_coroutine_fns in qmp_block_resize(), Kevin Wolf, 2023/04/25
  - Re: [PATCH 04/20] block: Don't call no_coroutine_fns in qmp_block_resize(), Eric Blake, 2023/04/25
    - Re: [PATCH 04/20] block: Don't call no_coroutine_fns in qmp_block_resize(), Kevin Wolf, 2023/04/27
    - Re: [PATCH 04/20] block: Don't call no_coroutine_fns in qmp_block_resize(), Eric Blake, 2023/04/27
- [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context, Kevin Wolf, 2023/04/25
  - Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context, Eric Blake, 2023/04/25
  - Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context, Paolo Bonzini, 2023/04/27
    - Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context, Kevin Wolf, 2023/04/27
    - Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context, Paolo Bonzini <=
- [PATCH 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR), Kevin Wolf, 2023/04/25
  - Re: [PATCH 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR), Eric Blake, 2023/04/25
- [PATCH 10/20] nbd: Mark nbd_co_do_establish_connection() and callers GRAPH_RDLOCK, Kevin Wolf, 2023/04/25
  - Re: [PATCH 10/20] nbd: Mark nbd_co_do_establish_connection() and callers GRAPH_RDLOCK, Eric Blake, 2023/04/25
- [PATCH 05/20] test-bdrv-drain: Don't modify the graph in coroutines, Kevin Wolf, 2023/04/25
  - Re: [PATCH 05/20] test-bdrv-drain: Don't modify the graph in coroutines, Eric Blake, 2023/04/25
- [PATCH 07/20] graph-lock: Fix GRAPH_RDLOCK_GUARD*() to be reader lock, Kevin Wolf, 2023/04/25
  - Re: [PATCH 07/20] graph-lock: Fix GRAPH_RDLOCK_GUARD*() to be reader lock, Eric Blake, 2023/04/25
    - Re: [PATCH 07/20] graph-lock: Fix GRAPH_RDLOCK_GUARD*() to be reader lock, Kevin Wolf, 2023/04/27
    - Re: [PATCH 07/20] graph-lock: Fix GRAPH_RDLOCK_GUARD*() to be reader lock, Eric Blake, 2023/04/27

Prev by Date: Re: [PATCH v3 1/4] block/meson.build: prefer positive condition for replication
Next by Date: [PATCH 0/2] target/riscv: RVV 1-fill tail element changes
Previous by thread: Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context
Next by thread: [PATCH 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR)
Index(es):
- Date
- Thread