qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR)


From: Eric Blake
Subject: Re: [PATCH 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR)
Date: Tue, 25 Apr 2023 15:20:33 -0500
User-agent: NeoMutt/20230407

On Tue, Apr 25, 2023 at 07:31:44PM +0200, Kevin Wolf wrote:
> For some function, parts of their interface is that are called without
> holding the graph lock. Add a new macro to document this.

Grammar is off; maybe:

For some functions, it is part of their interface to be called without
holding the graph lock.

> 
> The macro expands to TSA_EXCLUDES(), which is a relatively weak check
> because it passes in cases where the compiler just doesn't know if the
> lock is held. Function pointers can't be checked at all. Therefore, its
> primary purpose is documentation.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  include/block/graph-lock.h | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Eric blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]