Re: [PATCH v9 7/8] memory: abort on re-entrancy in debug builds

[Thomas Huth]

On 27/04/2023 16.44, Alexander Bulekov wrote:
> On 230426 1219, Alexander Bulekov wrote:
> > This is useful for using unit-tests/fuzzing to detect bugs introduced by
> > the re-entrancy guard mechanism into devices that are intentionally
> > re-entrant.
> >
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > ---
>
> This doesn't actually do anything right now. Doesn't look like DEBUG is
> defined with --enable-debug

Ah, I thought you'd enable it with --extra-cflags=-DDEBUG or so

> Any suggestion for how to make re-entrancy louder/fatal on
> debug/developer builds? Maybe we can just replace the trace event with
> an unconditional log-message?

I'm not sure whether I'd go for a completely uncondition log message, but 
maybe qemu_log_mask(LOG_GUEST_ERROR, ...) is ok?

 Thomas