[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 5/8] lsi53c895a: disable reentrancy detection for script RAM
From: |
Alexander Bulekov |
Subject: |
[PATCH v9 5/8] lsi53c895a: disable reentrancy detection for script RAM |
Date: |
Wed, 26 Apr 2023 12:19:48 -0400 |
As the code is designed to use the memory APIs to access the script ram,
disable reentrancy checks for the pseudo-RAM ram_io MemoryRegion.
In the future, ram_io may be converted from an IO to a proper RAM MemoryRegion.
Reported-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
---
hw/scsi/lsi53c895a.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index af93557a9a..db27872963 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -2302,6 +2302,12 @@ static void lsi_scsi_realize(PCIDevice *dev, Error
**errp)
memory_region_init_io(&s->io_io, OBJECT(s), &lsi_io_ops, s,
"lsi-io", 256);
+ /*
+ * Since we use the address-space API to interact with ram_io, disable the
+ * re-entrancy guard.
+ */
+ s->ram_io.disable_reentrancy_guard = true;
+
address_space_init(&s->pci_io_as, pci_address_space_io(dev), "lsi-pci-io");
qdev_init_gpio_out(d, &s->ext_irq, 1);
--
2.39.0
- [PATCH v9 0/8] memory: prevent dma-reentracy issues, Alexander Bulekov, 2023/04/26
- [PATCH v9 2/8] async: Add an optional reentrancy guard to the BH API, Alexander Bulekov, 2023/04/26
- [PATCH v9 3/8] checkpatch: add qemu_bh_new/aio_bh_new checks, Alexander Bulekov, 2023/04/26
- [PATCH v9 8/8] raven: disable reentrancy detection for iomem, Alexander Bulekov, 2023/04/26
- [PATCH v9 5/8] lsi53c895a: disable reentrancy detection for script RAM,
Alexander Bulekov <=
- [PATCH v9 1/8] memory: prevent dma-reentracy issues, Alexander Bulekov, 2023/04/26
- [PATCH v9 6/8] bcm2835_property: disable reentrancy detection for iomem, Alexander Bulekov, 2023/04/26
- [PATCH v9 4/8] hw: replace most qemu_bh_new calls with qemu_bh_new_guarded, Alexander Bulekov, 2023/04/26
- [PATCH v9 7/8] memory: abort on re-entrancy in debug builds, Alexander Bulekov, 2023/04/26
- Re: [PATCH v9 0/8] memory: prevent dma-reentracy issues, Thomas Huth, 2023/04/27