Re: [PATCH 18/21] Hexagon (target/hexagon) Move new_pred_value to DisasContext

[Richard Henderson]

On 4/26/23 01:42, Taylor Simpson wrote:
> The new_pred_value array in the CPUHexagonState is only used for
> bookkeeping within the translation of a packet.  With recent changes
> that eliminate the need to free TCGv variables, these make more sense
> to be transient and kept in DisasContext.
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
>   target/hexagon/cpu.h                        |  1 -
>   target/hexagon/gen_tcg.h                    | 12 ++++++------
>   target/hexagon/translate.h                  |  2 +-
>   target/hexagon/genptr.c                     | 10 +++++++---
>   target/hexagon/idef-parser/parser-helpers.c |  2 +-
>   target/hexagon/op_helper.c                  |  2 +-
>   target/hexagon/translate.c                  | 16 ++++++----------
>   target/hexagon/gen_tcg_funcs.py             |  2 +-
>   8 files changed, 23 insertions(+), 24 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~