qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/21] Hexagon (target/hexagon) Short-circuit more HVX single


From: Richard Henderson
Subject: Re: [PATCH 14/21] Hexagon (target/hexagon) Short-circuit more HVX single instruction packets
Date: Thu, 27 Apr 2023 11:44:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 4/26/23 01:42, Taylor Simpson wrote:
The generated helpers for HVX use pass-by-reference, so they can't
short-circuit when the reads/writes overlap.  The instructions with
overrides are OK because they use tcg_gen_gvec_*.

We add a flag has_hvx_helper to DisasContext and extend gen_analyze_funcs
to set the flag when the instruction is an HVX instruction with a
generated helper.

We add an override for V6_vcombine so that it can be short-circuited
along with a test case in tests/tcg/hexagon/hvx_misc.c

Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
---
  target/hexagon/gen_tcg_hvx.h        | 23 +++++++++++++++++++++++
  target/hexagon/translate.h          |  1 +
  target/hexagon/translate.c          | 17 +++++++++++++++--
  tests/tcg/hexagon/hvx_misc.c        | 21 +++++++++++++++++++++
  target/hexagon/gen_analyze_funcs.py |  5 +++++
  5 files changed, 65 insertions(+), 2 deletions(-)

Ideally the vcombine override would be a separate patch.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]