Re: [PATCH v8 5/8] memory: Allow disabling re-entrancy checking per-MR

[Alexander Bulekov]

On 230425 0941, Thomas Huth wrote:
> On 21/04/2023 16.27, Alexander Bulekov wrote:
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
> > ---
> >   include/exec/memory.h | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/exec/memory.h b/include/exec/memory.h
> > index 6c0a5e68d3..4e9531bd8a 100644
> > --- a/include/exec/memory.h
> > +++ b/include/exec/memory.h
> > @@ -793,6 +793,9 @@ struct MemoryRegion {
> >       unsigned ioeventfd_nb;
> >       MemoryRegionIoeventfd *ioeventfds;
> >       RamDiscardManager *rdm; /* Only for RAM */
> > +
> > +    /* For devices designed to perform re-entrant IO into their own IO MRs 
> > */
> > +    bool disable_reentrancy_guard;
> >   };
> >   struct IOMMUMemoryRegion {
> 
> Oh, wait, that check for "!mr->disable_reentrancy_guard" has been squashed
> into the first patch now ... that's bad, I think you should squash this into
> the first patch now, too!
> 

Oh.. Thanks for catching that.