qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 5/8] memory: Allow disabling re-entrancy checking per-MR


From: Thomas Huth
Subject: Re: [PATCH v8 5/8] memory: Allow disabling re-entrancy checking per-MR
Date: Tue, 25 Apr 2023 09:41:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 21/04/2023 16.27, Alexander Bulekov wrote:
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
---
  include/exec/memory.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/include/exec/memory.h b/include/exec/memory.h
index 6c0a5e68d3..4e9531bd8a 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -793,6 +793,9 @@ struct MemoryRegion {
      unsigned ioeventfd_nb;
      MemoryRegionIoeventfd *ioeventfds;
      RamDiscardManager *rdm; /* Only for RAM */
+
+    /* For devices designed to perform re-entrant IO into their own IO MRs */
+    bool disable_reentrancy_guard;
  };
struct IOMMUMemoryRegion {

Oh, wait, that check for "!mr->disable_reentrancy_guard" has been squashed into the first patch now ... that's bad, I think you should squash this into the first patch now, too!

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]