|
From: | Paolo Bonzini |
Subject: | Re: [RFC PATCH v3 00/20] configure: create a python venv and ensure meson, sphinx |
Date: | Wed, 26 Apr 2023 10:49:15 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 |
On 4/26/23 10:05, Paolo Bonzini wrote:
Thanks, this looks pretty good. Some changes I'd make for the non-RFC version:- I think we should just check in the meson wheel (which also removes the need for patch 12, so it can be done in its stead) and remove the submodule- The verbosity of mkvenv.py can be tuned down and most prints replaced with logger.info() or logger.debug()- While I agree with keeping patch 18 separate, I would move it earlier so that patch 19 can be squashed into patch 14- I am ambivalent about keeping --enable/--disable-pypi in the first committed patchset, but in any case I would move patches 16 and 20 before patch 15
Just one extra thing, since we're changing so much of Python handling and since the code is written, I would keep the Debian 10 workarounds for now, and only drop them after we drop support for 3.6.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |