[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 20/47] igb: Remove goto
From: |
Akihiko Odaki |
Subject: |
[PATCH v3 20/47] igb: Remove goto |
Date: |
Sun, 23 Apr 2023 13:18:06 +0900 |
The goto is a bit confusing as it changes the control flow only if L4
protocol is not recognized. It is also different from e1000e, and
noisy when comparing e1000e and igb.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
---
hw/net/igb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 167e1f949d..2de04fabfe 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1297,7 +1297,7 @@ igb_build_rx_metadata(IGBCore *core,
break;
default:
- goto func_exit;
+ break;
}
} else {
trace_e1000e_rx_metadata_l4_cso_disabled();
--
2.40.0
- [PATCH v3 11/47] tests/avocado: Remove unused imports, (continued)
- [PATCH v3 11/47] tests/avocado: Remove unused imports, Akihiko Odaki, 2023/04/23
- [PATCH v3 12/47] tests/avocado: Remove test_igb_nomsi_kvm, Akihiko Odaki, 2023/04/23
- [PATCH v3 13/47] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info, Akihiko Odaki, 2023/04/23
- [PATCH v3 14/47] net/eth: Rename eth_setup_vlan_headers_ex, Akihiko Odaki, 2023/04/23
- [PATCH v3 15/47] e1000x: Share more Rx filtering logic, Akihiko Odaki, 2023/04/23
- [PATCH v3 16/47] e1000x: Take CRC into consideration for size check, Akihiko Odaki, 2023/04/23
- [PATCH v3 17/47] e1000x: Rename TcpIpv6 into TcpIpv6Ex, Akihiko Odaki, 2023/04/23
- [PATCH v3 19/47] igb: Always log status after building rx metadata, Akihiko Odaki, 2023/04/23
- [PATCH v3 21/47] igb: Read DCMD.VLE of the first Tx descriptor, Akihiko Odaki, 2023/04/23
- [PATCH v3 23/47] vmxnet3: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/23
- [PATCH v3 20/47] igb: Remove goto,
Akihiko Odaki <=
- [PATCH v3 22/47] e1000e: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/23
- [PATCH v3 18/47] e1000e: Always log status after building rx metadata, Akihiko Odaki, 2023/04/23
- [PATCH v3 24/47] igb: Add more definitions for Tx descriptor, Akihiko Odaki, 2023/04/23
- [PATCH v3 25/47] igb: Share common VF constants, Akihiko Odaki, 2023/04/23
- [PATCH v3 26/47] igb: Fix igb_mac_reg_init coding style alignment, Akihiko Odaki, 2023/04/23
- [PATCH v3 27/47] igb: Clear EICR bits for delayed MSI-X interrupts, Akihiko Odaki, 2023/04/23
- [PATCH v3 29/47] igb: Rename a variable in igb_receive_internal(), Akihiko Odaki, 2023/04/23
- [PATCH v3 30/47] net/eth: Use void pointers, Akihiko Odaki, 2023/04/23
- [PATCH v3 28/47] e1000e: Rename a variable in e1000e_receive_internal(), Akihiko Odaki, 2023/04/23