Re: [PATCH 01/11] Signed-off-by: Karim Taha <address@hidden>

[Karim Taha]

I made a fork on gitlab and pushed a branch at https://gitlab.com/Kariiem/qemu/-/tree/gsoc23-task3/ .

On Sat, Apr 22, 2023 at 1:18 AM Warner Losh <imp@bsdimp.com> wrote:

Usually this means pushing a branch off of mastar to a service like github or gitlab, and then

posting a URL with where to get it.

Warner

On Fri, Apr 21, 2023 at 4:40 PM Karim Taha <kariem.taha2.7@gmail.com> wrote:

It was sent with git-publish, what do you mean by pointing to a branch?

On Fri, Apr 21, 2023 at 7:22 PM Alex Bennée <alex.bennee@linaro.org> wrote:

Karim Taha <kariem.taha2.7@gmail.com> writes:

> On Fri, Apr 21, 2023 at 9:17 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
>  On Fri, Apr 21, 2023 at 07:22:45AM +0200, Karim Taha wrote:
>  > From: Warner Losh <imp@bsdimp.com>
>  >
>  > Allow guest_base to be initialized on 64-bit hosts, the initial value is used by g2h_untagged function
>  defined in include/exec/cpu_ldst.h
>
>  This commit message is all incorrectly structured I'm afraid.
>
>  There needs to a short 1 line summary, then a blank line,
>  then the full commit description text, then a blank line,
>  then the Signed-off-by tag(s).
>
>  Also if you're sending work done by Warner (as the From
>  tag suggests), then we would expect to see Warner's own
>  Signed-off-by tag, in addition to your own Signed-off-by.
<snip>
>
> Alright, thanks for the commit formatting tips, I resent the patch series, with my signed off by tag and the
> author signed off by tags as well.

Hmm something has gone wrong. Was this sent with a plain git-send-email
or using a tool like git-publish?

Can you point to a branch?

>
> Best regards,
> Karim


--
Alex Bennée
Virtualisation Tech Lead @ Linaro