[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] Signed-off-by: Karim Taha <address@hidden>
From: |
Alex Bennée |
Subject: |
Re: [PATCH 01/11] Signed-off-by: Karim Taha <address@hidden> |
Date: |
Fri, 21 Apr 2023 18:21:03 +0100 |
User-agent: |
mu4e 1.11.2; emacs 29.0.90 |
Karim Taha <kariem.taha2.7@gmail.com> writes:
> On Fri, Apr 21, 2023 at 9:17 AM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
>
> On Fri, Apr 21, 2023 at 07:22:45AM +0200, Karim Taha wrote:
> > From: Warner Losh <imp@bsdimp.com>
> >
> > Allow guest_base to be initialized on 64-bit hosts, the initial value is
> used by g2h_untagged function
> defined in include/exec/cpu_ldst.h
>
> This commit message is all incorrectly structured I'm afraid.
>
> There needs to a short 1 line summary, then a blank line,
> then the full commit description text, then a blank line,
> then the Signed-off-by tag(s).
>
> Also if you're sending work done by Warner (as the From
> tag suggests), then we would expect to see Warner's own
> Signed-off-by tag, in addition to your own Signed-off-by.
<snip>
>
> Alright, thanks for the commit formatting tips, I resent the patch series,
> with my signed off by tag and the
> author signed off by tags as well.
Hmm something has gone wrong. Was this sent with a plain git-send-email
or using a tool like git-publish?
Can you point to a branch?
>
> Best regards,
> Karim
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
[PATCH 02/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21
[PATCH 03/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21
[PATCH 04/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21
[PATCH 05/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21
[PATCH 06/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21
[PATCH 07/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21
[PATCH 08/11] Signed-off-by: Karim Taha <address@hidden>, Karim Taha, 2023/04/21