Re: [PATCH v2 RESEND 4/7] Hexagon: support qRegisterInfo at gdbstub

[Matheus Tavares Bernardino]

Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> > Matheus Tavares <quic_mathbern@quicinc.com> wrote:
> > 
> > diff --git a/target/hexagon/gdb_qreginfo.h b/target/hexagon/gdb_qreginfo.h
> > new file mode 100644
> > index 0000000000..64631ddd58
> > --- /dev/null
> > +++ b/target/hexagon/gdb_qreginfo.h
> 
> This should be gdb_qreginfo.h.inc

Ok, thanks.

> > @@ -358,6 +359,8 @@ static void hexagon_cpu_class_init(ObjectClass *c, void 
> > *data)
> >       cc->get_pc = hexagon_cpu_get_pc;
> >       cc->gdb_read_register = hexagon_gdb_read_register;
> >       cc->gdb_write_register = hexagon_gdb_write_register;
> > +    cc->gdb_qreg_info_lines = (const char **)hexagon_qreg_descs;
> 
> No need to cast if fixing gdb_qreg_info_lines's prototype
> (see previous patch review).

Ah, good call, thanks. I'll try to avoid the whole qRegisterInfo
implemenation in the next round, as Alex suggested [1]. But if not
possible, I'll make sure to add this changes to the types and cast.
Thanks!

[1]: 
20230421113420.67122-1-quic_mathbern@quicinc.com/">https://lore.kernel.org/qemu-devel/20230421113420.67122-1-quic_mathbern@quicinc.com/