Re: [PATCH v2 RESEND 3/7] gdbstub: add support for the qRegisterInfo query

[Philippe Mathieu-Daudé]

On 20/4/23 14:31, Matheus Tavares Bernardino wrote:
> From: Brian Cain <bcain@quicinc.com>
>
> Signed-off-by: Brian Cain <bcain@quicinc.com>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
>   include/hw/core/cpu.h |  4 ++++
>   gdbstub/gdbstub.c     | 27 +++++++++++++++++++++++++++
>   2 files changed, 31 insertions(+)


> @@ -159,6 +161,8 @@ struct CPUClass {
>       vaddr (*gdb_adjust_breakpoint)(CPUState *cpu, vaddr addr);
>   
>       const char *gdb_core_xml_file;
> +    const char **gdb_qreg_info_lines;

Shouldn't this be 'const char *const *gdb_qreg_info_lines;'?

> +    int gdb_qreg_info_line_count;
>       gchar * (*gdb_arch_name)(CPUState *cpu);
>       const char * (*gdb_get_dynamic_xml)(CPUState *cpu, const char *xmlname);