qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/10] trace-events: remove the remaining vcpu trace events


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 02/10] trace-events: remove the remaining vcpu trace events
Date: Fri, 21 Apr 2023 08:47:39 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 20/4/23 17:00, Alex Bennée wrote:
While these are all in helper functions being designated vcpu events
complicates the removal of the dynamic vcpu state code. TCG plugins
allow you to instrument vcpu_[init|exit|idle].

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  hw/core/cpu-common.c   |  2 --
  trace/control-target.c |  1 -
  trace/control.c        |  2 --
  trace-events           | 31 -------------------------------
  4 files changed, 36 deletions(-)

diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c
index 5ccc3837b6..8373a500d2 100644
--- a/hw/core/cpu-common.c
+++ b/hw/core/cpu-common.c
@@ -112,8 +112,6 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags)
  void cpu_reset(CPUState *cpu)
  {
      device_cold_reset(DEVICE(cpu));
-
-    trace_guest_cpu_reset(cpu);
  }

Can we convert this one to a "normal" trace event instead of
removing it? I find it helpful in build configured without plugin.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]