Re: [PATCH 09/10] hw/9pfs: use qemu_xxhash4

[Christian Schoenebeck]

On Thursday, April 20, 2023 5:00:08 PM CEST Alex Bennée wrote:
> No need to pass zeros as we have helpers that do that for us.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  hw/9pfs/9p.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 9621ec1341..9bf502c45f 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -741,12 +741,12 @@ static VariLenAffix affixForIndex(uint64_t index)
>  /* creative abuse of tb_hash_func7, which is based on xxhash */

I guess this old comment could be dropped then.

Except of that:

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

>  static uint32_t qpp_hash(QppEntry e)
>  {
> -    return qemu_xxhash7(e.ino_prefix, e.dev, 0, 0, 0);
> +    return qemu_xxhash4(e.ino_prefix, e.dev);
>  }
>  
>  static uint32_t qpf_hash(QpfEntry e)
>  {
> -    return qemu_xxhash7(e.ino, e.dev, 0, 0, 0);
> +    return qemu_xxhash4(e.ino, e.dev);
>  }
>  
>  static bool qpd_cmp_func(const void *obj, const void *userp)
>