[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 26/41] net/eth: Use void pointers
From: |
Akihiko Odaki |
Subject: |
[PATCH v2 26/41] net/eth: Use void pointers |
Date: |
Thu, 20 Apr 2023 14:46:42 +0900 |
The uses of uint8_t pointers were misleading as they are never accessed
as an array of octets and it even require more strict alignment to
access as struct eth_header.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/net/eth.h | 4 ++--
net/eth.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/net/eth.h b/include/net/eth.h
index 05f56931e7..95ff24d6b8 100644
--- a/include/net/eth.h
+++ b/include/net/eth.h
@@ -342,12 +342,12 @@ eth_get_pkt_tci(const void *p)
size_t
eth_strip_vlan(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint8_t *new_ehdr_buf,
+ void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci);
size_t
eth_strip_vlan_ex(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint16_t vet, uint8_t *new_ehdr_buf,
+ uint16_t vet, void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci);
uint16_t
diff --git a/net/eth.c b/net/eth.c
index b6ff89c460..f7ffbda600 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -226,11 +226,11 @@ void eth_get_protocols(const struct iovec *iov, size_t
iovcnt, size_t iovoff,
size_t
eth_strip_vlan(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint8_t *new_ehdr_buf,
+ void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci)
{
struct vlan_header vlan_hdr;
- struct eth_header *new_ehdr = (struct eth_header *) new_ehdr_buf;
+ struct eth_header *new_ehdr = new_ehdr_buf;
size_t copied = iov_to_buf(iov, iovcnt, iovoff,
new_ehdr, sizeof(*new_ehdr));
@@ -276,7 +276,7 @@ eth_strip_vlan(const struct iovec *iov, int iovcnt, size_t
iovoff,
size_t
eth_strip_vlan_ex(const struct iovec *iov, int iovcnt, size_t iovoff,
- uint16_t vet, uint8_t *new_ehdr_buf,
+ uint16_t vet, void *new_ehdr_buf,
uint16_t *payload_offset, uint16_t *tci)
{
struct vlan_header vlan_hdr;
--
2.40.0
- Re: [PATCH v2 16/41] e1000x: Rename TcpIpv6 into TcpIpv6Ex, (continued)
- [PATCH v2 17/41] e1000e: Always log status after building rx metadata, Akihiko Odaki, 2023/04/20
- [PATCH v2 13/41] net/eth: Rename eth_setup_vlan_headers_ex, Akihiko Odaki, 2023/04/20
- [PATCH v2 18/41] igb: Always log status after building rx metadata, Akihiko Odaki, 2023/04/20
- [PATCH v2 19/41] igb: Remove goto, Akihiko Odaki, 2023/04/20
- [PATCH v2 20/41] igb: Read DCMD.VLE of the first Tx descriptor, Akihiko Odaki, 2023/04/20
- [PATCH v2 21/41] e1000e: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/20
- [PATCH v2 22/41] vmxnet3: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/20
- [PATCH v2 25/41] igb: Fix igb_mac_reg_init coding style alignment, Akihiko Odaki, 2023/04/20
- [PATCH v2 26/41] net/eth: Use void pointers,
Akihiko Odaki <=
- [PATCH v2 23/41] igb: Add more definitions for Tx descriptor, Akihiko Odaki, 2023/04/20
- [PATCH v2 24/41] igb: Share common VF constants, Akihiko Odaki, 2023/04/20
- [PATCH v2 28/41] hw/net/net_rx_pkt: Enforce alignment for eth_header, Akihiko Odaki, 2023/04/20
- [PATCH v2 29/41] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX, Akihiko Odaki, 2023/04/20
- [PATCH v2 30/41] igb: Implement MSI-X single vector mode, Akihiko Odaki, 2023/04/20
- [PATCH v2 31/41] igb: Use UDP for RSS hash, Akihiko Odaki, 2023/04/20