[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 19/41] igb: Remove goto
From: |
Akihiko Odaki |
Subject: |
[PATCH v2 19/41] igb: Remove goto |
Date: |
Thu, 20 Apr 2023 14:46:35 +0900 |
The goto is a bit confusing as it changes the control flow only if L4
protocol is not recognized. It is also different from e1000e, and
noisy when comparing e1000e and igb.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
---
hw/net/igb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index dabf1a91d8..d966aa6bfa 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1297,7 +1297,7 @@ igb_build_rx_metadata(IGBCore *core,
break;
default:
- goto func_exit;
+ break;
}
} else {
trace_e1000e_rx_metadata_l4_cso_disabled();
--
2.40.0
- [PATCH v2 12/41] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info, (continued)
- [PATCH v2 12/41] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info, Akihiko Odaki, 2023/04/20
- [PATCH v2 14/41] e1000x: Share more Rx filtering logic, Akihiko Odaki, 2023/04/20
- [PATCH v2 15/41] e1000x: Take CRC into consideration for size check, Akihiko Odaki, 2023/04/20
- [PATCH v2 16/41] e1000x: Rename TcpIpv6 into TcpIpv6Ex, Akihiko Odaki, 2023/04/20
- [PATCH v2 17/41] e1000e: Always log status after building rx metadata, Akihiko Odaki, 2023/04/20
- [PATCH v2 13/41] net/eth: Rename eth_setup_vlan_headers_ex, Akihiko Odaki, 2023/04/20
- [PATCH v2 18/41] igb: Always log status after building rx metadata, Akihiko Odaki, 2023/04/20
- [PATCH v2 19/41] igb: Remove goto,
Akihiko Odaki <=
- [PATCH v2 20/41] igb: Read DCMD.VLE of the first Tx descriptor, Akihiko Odaki, 2023/04/20
- [PATCH v2 21/41] e1000e: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/20
- [PATCH v2 22/41] vmxnet3: Reset packet state after emptying Tx queue, Akihiko Odaki, 2023/04/20
- [PATCH v2 25/41] igb: Fix igb_mac_reg_init coding style alignment, Akihiko Odaki, 2023/04/20
- [PATCH v2 26/41] net/eth: Use void pointers, Akihiko Odaki, 2023/04/20
- [PATCH v2 23/41] igb: Add more definitions for Tx descriptor, Akihiko Odaki, 2023/04/20
- [PATCH v2 24/41] igb: Share common VF constants, Akihiko Odaki, 2023/04/20
- [PATCH v2 28/41] hw/net/net_rx_pkt: Enforce alignment for eth_header, Akihiko Odaki, 2023/04/20