[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] io: mark mixed functions that can suspend
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] io: mark mixed functions that can suspend |
Date: |
Tue, 18 Apr 2023 17:27:37 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Thu, Apr 06, 2023 at 12:28:00PM +0200, Paolo Bonzini wrote:
> There should be no paths from a coroutine_fn to aio_poll, however in
> practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
> path. By marking mixed functions, we can track accurately the call paths
> that execute entirely in coroutine context, and find more missing
> coroutine_fn markers. This results in more accurate checks that
> coroutine code does not end up blocking.
>
> If the marking were extended transitively to all functions that call
> these ones, static analysis could be done much more efficiently.
> However, this is a start and makes it possible to use vrc's path-based
> searches to find potential bugs where coroutine_fns call blocking functions.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> include/io/channel.h | 78 ++++++++++++++++++++++----------------------
> io/channel.c | 78 ++++++++++++++++++++++----------------------
> 2 files changed, 78 insertions(+), 78 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|