[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] test: Fix test-crypto-secret when compiling without keyri
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3] test: Fix test-crypto-secret when compiling without keyring support |
|
Date: |
Tue, 18 Apr 2023 17:24:14 +0100 |
|
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Fri, Apr 14, 2023 at 01:42:52PM +0200, Juan Quintela wrote:
> Linux keyring support is protected by CONFIG_KEYUTILS.
> We also need CONFIG_SECRET_KEYRING.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> - Previous version of this patch changed the meson build rules.
> Daniel told me that the proper fix was to change the #ifdef test.
>
> - Change rule again. We need both defines.
> - Put both defines in #endif (thomas)
> ---
> tests/unit/test-crypto-secret.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|