|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/3] target/arm: Set ptw->out_secure correctly for stage 2 translations |
Date: | Tue, 18 Apr 2023 13:01:49 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 4/14/23 18:04, Peter Maydell wrote:
+ /* Check if page table walk is to secure or non-secure PA space. */ + ptw->out_secure = (is_secure + && !(pte_secure + ? env->cp15.vstcr_el2 & VSTCR_SW + : env->cp15.vtcr_el2 & VTCR_NSW)); + } else { + /* Regime is physical */ + ptw->out_secure = pte_secure;
Is that last comment really correct? I think it could still be stage1 of 2. That said, the actual code looks correct. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |