|
From: | Paul Durrant |
Subject: | Re: [PATCH 2/5] hw/xen: Fix memory leak in libxenstore_open() for Xen |
Date: | Mon, 17 Apr 2023 13:28:50 +0100 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 12/04/2023 19:50, David Woodhouse wrote:
From: David Woodhouse <dwmw@amazon.co.uk> There was a superfluous allocation of the XS handle, leading to it being leaked on both the error path and the success path (where it gets allocated again). Spotted by Coverity (CID 1508098). Fixes: ba2a92db1ff6 ("hw/xen: Add xenstore operations to allow redirection to internal emulation") Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paul Durrant <paul@xen.org>
[Prev in Thread] | Current Thread | [Next in Thread] |