[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info()
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info() |
|
Date: |
Wed, 12 Apr 2023 19:59:19 +0100 |
On Wed, 12 Apr 2023 at 19:52, David Woodhouse <dwmw2@infradead.org> wrote:
>
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Coverity spotted a double-free (CID 1508254); we g_string_free(path) and
> then for some reason immediately call free(path) too.
>
> We should just use g_autoptr() for it anyway, which simplifies the code
> a bit.
>
> Fixes: 7a8a749da7d3 ("hw/xen: Move xenstore_store_pv_console_info to
> xen_console.c")
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes, David Woodhouse, 2023/04/12
- [PATCH 5/5] hw/xen: Fix broken check for invalid state in xs_be_open(), David Woodhouse, 2023/04/12
- [PATCH 1/5] hw/xen: Simplify emulated Xen platform init, David Woodhouse, 2023/04/12
- [PATCH 4/5] hw/xen: Fix double-free in xen_console store_con_info(), David Woodhouse, 2023/04/12
- [PATCH 2/5] hw/xen: Fix memory leak in libxenstore_open() for Xen, David Woodhouse, 2023/04/12
- [PATCH 3/5] xen: Drop support for Xen versions below 4.7.1, David Woodhouse, 2023/04/12
- Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes, Peter Maydell, 2023/04/12
- Re: [PATCH for-8.0 0/5] Xen emulation build/Coverity fixes, Stefano Stabellini, 2023/04/12