Re: [PATCH 10/16] hw/i3c/aspeed_i3c: Add IBI handling

[Joe Komlodi]

Hi jeremy,

On Tue, Apr 11, 2023 at 2:17 AM Jeremy Kerr <jk@codeconstruct.com.au> wrote:
>
> Hi Joe,
>
> > +static int aspeed_i3c_device_ibi_finish(I3CBus *bus)
> > +{
> > +    AspeedI3CDevice *s = ASPEED_I3C_DEVICE(bus->qbus.parent);
> > +    bool nack_and_disable_hj = ARRAY_FIELD_EX32(s->regs, DEVICE_CTRL,
> > +                                                HOT_JOIN_ACK_NACK_CTRL);
> > +    if (nack_and_disable_hj || s->ibi_data.send_direct_disec) {
> > +        aspeed_i3c_device_send_disec(s);
> > +    }
>
> Shouldn't this be conditional on the ibi being a HJ request? With this,
> I'm seeing the DISEC happen on *all* IBIs.

Good catch! Yep it should be on HJs only.
Will fix in v2 as well.

Thanks,
Joe

>
> Cheers,
>
>
> Jeremy
>