[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/16] hw/i3c/aspeed_i3c: Add IBI handling
|
From: |
Jeremy Kerr |
|
Subject: |
Re: [PATCH 10/16] hw/i3c/aspeed_i3c: Add IBI handling |
|
Date: |
Tue, 11 Apr 2023 17:16:53 +0800 |
|
User-agent: |
Evolution 3.46.3-1 |
Hi Joe,
> +static int aspeed_i3c_device_ibi_finish(I3CBus *bus)
> +{
> + AspeedI3CDevice *s = ASPEED_I3C_DEVICE(bus->qbus.parent);
> + bool nack_and_disable_hj = ARRAY_FIELD_EX32(s->regs, DEVICE_CTRL,
> + HOT_JOIN_ACK_NACK_CTRL);
> + if (nack_and_disable_hj || s->ibi_data.send_direct_disec) {
> + aspeed_i3c_device_send_disec(s);
> + }
Shouldn't this be conditional on the ibi being a HJ request? With this,
I'm seeing the DISEC happen on *all* IBIs.
Cheers,
Jeremy