qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 18/19] bsd-user: Update system call list


From: Warner Losh
Subject: Re: [PATCH v2 18/19] bsd-user: Update system call list
Date: Mon, 10 Apr 2023 20:37:21 -0600



On Mon, Apr 10, 2023 at 7:37 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 4/10/23 11:20, Warner Losh wrote:
> Update the system call list. We have one hokey thing in here for swapoff
> that depends on the version number (so this is not completely generated
> at the moment). For this, we need to include sys/param.h. The method of
> generation has changed, so this diff looks way bigger than it needs to
> be to add the few lines of code for the new system calls.
>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>   bsd-user/freebsd/os-syscall.h |    2 +
>   bsd-user/freebsd/syscall_nr.h | 1035 +++++++++++++++++----------------
>   2 files changed, 529 insertions(+), 508 deletions(-)

What is the method of generation?

If it's complicated, it should be in scripts/.
If it's trivial, e.g.

     sed 's/xxx/yyy/' < in.h > out.h

it is worth including the command in the commit message.

I'll add it to the commit message... but I'm also contemplating generating it
on the fly if it's not too hard... Thanks for the suggestion... It's usually a sed,
but someone (likely me) edited it directly for an unwise hack that Ineed to
unwind first...
 
Anyway,
Acked-by: Richard Henderson <richard.henderson@linaro.org>

Warner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]