Re: [PATCH v2 18/19] bsd-user: Update system call list

[Richard Henderson]

On 4/10/23 11:20, Warner Losh wrote:
> Update the system call list. We have one hokey thing in here for swapoff
> that depends on the version number (so this is not completely generated
> at the moment). For this, we need to include sys/param.h. The method of
> generation has changed, so this diff looks way bigger than it needs to
> be to add the few lines of code for the new system calls.
>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>   bsd-user/freebsd/os-syscall.h |    2 +
>   bsd-user/freebsd/syscall_nr.h | 1035 +++++++++++++++++----------------
>   2 files changed, 529 insertions(+), 508 deletions(-)

What is the method of generation?

If it's complicated, it should be in scripts/.
If it's trivial, e.g.

    sed 's/xxx/yyy/' < in.h > out.h

it is worth including the command in the commit message.

Anyway,
Acked-by: Richard Henderson <richard.henderson@linaro.org>


r~