[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/7] target/riscv: Remove pc_succ_insn from DisasContext
From: |
Weiwei Li |
Subject: |
[PATCH 7/7] target/riscv: Remove pc_succ_insn from DisasContext |
Date: |
Sun, 9 Apr 2023 18:53:06 +0800 |
pc_succ_insn is no longer useful after the introduce of cur_insn_len
and all pc related value use diff value instead of absolute value.
Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
---
target/riscv/translate.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 632e1cef59..d8899fcc4b 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -1150,7 +1150,6 @@ static void decode_opc(CPURISCVState *env, DisasContext
*ctx, uint16_t opcode)
/* Check for compressed insn */
if (ctx->cur_insn_len == 2) {
ctx->opcode = opcode;
- ctx->pc_succ_insn = ctx->base.pc_next + 2;
if (has_ext(ctx, RVC) && decode_insn16(ctx, opcode)) {
return;
}
@@ -1160,7 +1159,6 @@ static void decode_opc(CPURISCVState *env, DisasContext
*ctx, uint16_t opcode)
translator_lduw(env, &ctx->base,
ctx->base.pc_next + 2));
ctx->opcode = opcode32;
- ctx->pc_succ_insn = ctx->base.pc_next + 4;
for (size_t i = 0; i < ARRAY_SIZE(decoders); ++i) {
if (decoders[i].guard_func(ctx) &&
@@ -1181,7 +1179,6 @@ static void riscv_tr_init_disas_context(DisasContextBase
*dcbase, CPUState *cs)
uint32_t tb_flags = ctx->base.tb->flags;
ctx->pc_save = ctx->base.pc_first;
- ctx->pc_succ_insn = ctx->base.pc_first;
ctx->mem_idx = FIELD_EX32(tb_flags, TB_FLAGS, MEM_IDX);
ctx->mstatus_fs = tb_flags & TB_FLAGS_MSTATUS_FS;
ctx->mstatus_vs = tb_flags & TB_FLAGS_MSTATUS_VS;
@@ -1244,7 +1241,7 @@ static void riscv_tr_translate_insn(DisasContextBase
*dcbase, CPUState *cpu)
ctx->ol = ctx->xl;
decode_opc(env, ctx, opcode16);
- ctx->base.pc_next = ctx->pc_succ_insn;
+ ctx->base.pc_next += ctx->cur_insn_len;
/* Only the first insn within a TB is allowed to cross a page boundary. */
if (ctx->base.is_jmp == DISAS_NEXT) {
--
2.25.1
- [PATCH 0/7] target/riscv: Add support for PC-relative translation, Weiwei Li, 2023/04/09
- [PATCH 7/7] target/riscv: Remove pc_succ_insn from DisasContext,
Weiwei Li <=
- [PATCH 5/7] target/riscv: Use true diff for gen_pc_plus_diff, Weiwei Li, 2023/04/09
- [PATCH 1/7] target/riscv: Fix target address to update badaddr, Weiwei Li, 2023/04/09
- [PATCH 3/7] target/riscv: Change gen_goto_tb to work on displacements, Weiwei Li, 2023/04/09
- [PATCH 2/7] target/riscv: Introduce cur_insn_len into DisasContext, Weiwei Li, 2023/04/09
- [PATCH 4/7] target/riscv: Change gen_set_pc_imm to gen_update_pc, Weiwei Li, 2023/04/09
- [PATCH 6/7] target/riscv: Enable PC-relative translation, Weiwei Li, 2023/04/09