Re: [PATCH v2 2/2] target/riscv: Legalize MPP value in write_mstatus

[liweiwei]

On 2023/4/7 03:28, Richard Henderson wrote:
> On 4/6/23 00:25, Weiwei Li wrote:
> >   void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv)
> >   {
> > -    if (newpriv > PRV_M) {
> > +    if (newpriv > PRV_M || newpriv == PRV_H) {
> >           g_assert_not_reached();
> >       }
>
> Nit: if (test) { assert_not_reached } -> assert(!test).
>
> which emits a more helpful error message before abort.
OK. I'll update this.

Regards,

Weiwei Li

> r~