|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 2/2] target/riscv: Legalize MPP value in write_mstatus |
Date: | Thu, 6 Apr 2023 12:28:44 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
On 4/6/23 00:25, Weiwei Li wrote:
void riscv_cpu_set_mode(CPURISCVState *env, target_ulong newpriv) { - if (newpriv > PRV_M) { + if (newpriv > PRV_M || newpriv == PRV_H) { g_assert_not_reached(); }
Nit: if (test) { assert_not_reached } -> assert(!test). which emits a more helpful error message before abort. r~
[Prev in Thread] | Current Thread | [Next in Thread] |