[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/6] target/riscv: Fix pointer mask transformation for vec
From: |
Alistair Francis |
Subject: |
Re: [PATCH v6 1/6] target/riscv: Fix pointer mask transformation for vector address |
Date: |
Wed, 5 Apr 2023 14:38:07 +1000 |
On Tue, Apr 4, 2023 at 12:09 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> actual_address = (requested_address & ~mpmmask) | mpmbase.
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
> Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/vector_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index 2423affe37..a58d82af8c 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -172,7 +172,7 @@ static inline uint32_t vext_get_total_elems(CPURISCVState
> *env, uint32_t desc,
>
> static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong addr)
> {
> - return (addr & env->cur_pmmask) | env->cur_pmbase;
> + return (addr & ~env->cur_pmmask) | env->cur_pmbase;
> }
>
> /*
> --
> 2.25.1
>
>
- [PATCH v6 0/6] target/riscv: Fix pointer mask related support, Weiwei Li, 2023/04/03
- [PATCH v6 5/6] target/riscv: Enable PC-relative translation in system mode, Weiwei Li, 2023/04/03
- [PATCH v6 2/6] target/riscv: Update cur_pmmask/base when xl changes, Weiwei Li, 2023/04/03
- [PATCH v6 3/6] target/riscv: Fix target address to update badaddr, Weiwei Li, 2023/04/03
- [PATCH v6 1/6] target/riscv: Fix pointer mask transformation for vector address, Weiwei Li, 2023/04/03
- Re: [PATCH v6 1/6] target/riscv: Fix pointer mask transformation for vector address,
Alistair Francis <=
- [PATCH v6 6/6] target/riscv: Add pointer mask support for instruction fetch, Weiwei Li, 2023/04/03
- [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, Weiwei Li, 2023/04/03
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, LIU Zhiwei, 2023/04/03
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, LIU Zhiwei, 2023/04/03
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, liweiwei, 2023/04/03
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, LIU Zhiwei, 2023/04/04
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, liweiwei, 2023/04/04
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, LIU Zhiwei, 2023/04/04
- Re: [PATCH v6 4/6] target/riscv: Add support for PC-relative translation, Richard Henderson, 2023/04/04