qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo


From: Paolo Bonzini
Subject: Re: [PATCH v2 10/10] hmp: Deprecate 'singlestep' member of StatusInfo
Date: Tue, 4 Apr 2023 16:55:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 4/4/23 16:24, Peter Maydell wrote:
I think on balance I would go for:
  * remove (ie deprecate-and-drop) 'singlestep' from the QMP struct,
    rather than merely renaming it
  * if anybody comes along and says they want to do this via QMP,
    implement Paolo's idea of putting the accelerator object
    somewhere they can get at it and use qom-get/qom-set on it
    [My guess is this is very unlikely: nobody's complained so
    far that QMP doesn't permit setting 'singlestep'; and
    wanting read without write seems even more marginal.]
  * keep the HMP commands, but have both read and write directly
    talk to the accel object. I favour splitting the 'read'
    part out into its own 'info one-insn-per-tb', for consistency
    (then 'info status' matches the QMP query-status)

I think the read part could be added to 'info jit'.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]