|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 03/10] tcg: Use one-insn-per-tb accelerator property in curr_cflags() |
Date: | Mon, 3 Apr 2023 11:33:49 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
On 4/3/23 07:46, Peter Maydell wrote:
uint32_t curr_cflags(CPUState *cpu) { uint32_t cflags = cpu->tcg_cflags; + TCGState *tcgstate = TCG_STATE(current_accel());
As mentioned against the cover, this is a very hot path. We should try for something less expensive. Perhaps as simple as return cpu->tcg_cflags | tcg_cflags_global; where cpu->tcg_cflags is updated with cpu->singlestep_enabled. r~
[Prev in Thread] | Current Thread | [Next in Thread] |