Re: [RFC PATCH v2 37/44] target/loongarch: Implement vfcmp

[Richard Henderson]

On 3/27/23 20:06, Song Gao wrote:
> +static uint64_t vfcmp_common(CPULoongArchState *env,
> +                             FloatRelation cmp, uint32_t flags)
> +{
> +    bool ret;
> +
> +    switch (cmp) {
> +    case float_relation_less:
> +        ret = (flags & FCMP_LT);
> +        break;
> +    case float_relation_equal:
> +        ret = (flags & FCMP_EQ);
> +        break;
> +    case float_relation_greater:
> +        ret = (flags & FCMP_GT);
> +        break;
> +    case float_relation_unordered:
> +        ret = (flags & FCMP_UN);
> +        break;
> +    default:
> +        g_assert_not_reached();
> +    }
> +
> +    return ret;
> +}

Either change the return type to bool, or return {0, -1} here...

> +
> +#define VFCMP(NAME, BIT, T, E, FN)                                       \
> +void HELPER(NAME)(CPULoongArchState *env,                                \
> +                  uint32_t vd, uint32_t vj, uint32_t vk, uint32_t flags) \
> +{                                                                        \
> +    int i;                                                               \
> +    VReg t;                                                              \
> +    VReg *Vd = &(env->fpr[vd].vreg);                                     \
> +    VReg *Vj = &(env->fpr[vj].vreg);                                     \
> +    VReg *Vk = &(env->fpr[vk].vreg);                                     \
> +                                                                         \
> +    vec_clear_cause(env);                                                \
> +    for (i = 0; i < LSX_LEN/BIT ; i++) {                                 \
> +        FloatRelation cmp;                                               \
> +        cmp = FN(Vj->E(i), Vk->E(i), &env->fp_status);                   \
> +        t.E(i) = (vfcmp_common(env, cmp, flags)) ? -1 : 0;               \

... and avoid the extra conditional here.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~