|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled |
Date: | Wed, 22 Mar 2023 15:32:38 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
On 22/3/23 15:29, Philippe Mathieu-Daudé wrote:
Fix when building QEMU configured with --disable-tcg: Undefined symbols for architecture arm64: "_arm_v7m_get_sp_ptr", referenced from: _m_sysreg_get in target_arm_gdbstub.c.o "_arm_v7m_mrs_control", referenced from: _arm_gdb_get_m_systemreg in target_arm_gdbstub.c.o "_pauth_ptr_mask", referenced from: _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
Beside having the non-TCG configs tested in CI, (I think) we can avoid such breakage by moving the TCG-specific declarations from target/arm/internals.h to some target/arm/tcg/tcg-internals.h header. (target/arm/internals.h is 1400+ LoC anyway). Worth it?
[Prev in Thread] | Current Thread | [Next in Thread] |