[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 14/23] hw/isa/piix4: Remove unused inbound ISA interrupt lines
From: |
Bernhard Beschow |
Subject: |
[PATCH v8 14/23] hw/isa/piix4: Remove unused inbound ISA interrupt lines |
Date: |
Thu, 2 Mar 2023 22:21:52 +0100 |
The Malta board, which is the only user of PIIX4, doesn't connect to the
exported interrupt lines. PIIX3 doesn't expose such interrupt lines
either, so remove them for PIIX4 for simplicity and consistency.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221022150508.26830-32-shentey@gmail.com>
---
hw/isa/piix4.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index c13f68733b..a88ae859c4 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -155,12 +155,6 @@ static void piix4_request_i8259_irq(void *opaque, int irq,
int level)
qemu_set_irq(s->cpu_intr, level);
}
-static void piix4_set_i8259_irq(void *opaque, int irq, int level)
-{
- PIIX4State *s = opaque;
- qemu_set_irq(s->isa[irq], level);
-}
-
static void piix4_rcr_write(void *opaque, hwaddr addr, uint64_t val,
unsigned int len)
{
@@ -204,8 +198,6 @@ static void piix4_realize(PCIDevice *dev, Error **errp)
return;
}
- qdev_init_gpio_in_named(DEVICE(dev), piix4_set_i8259_irq,
- "isa", ISA_NUM_IRQS);
qdev_init_gpio_out_named(DEVICE(dev), &s->cpu_intr,
"intr", 1);
--
2.39.2
- [PATCH v8 04/23] hw/isa/piix3: Create USB controller in host device, (continued)
- [PATCH v8 04/23] hw/isa/piix3: Create USB controller in host device, Bernhard Beschow, 2023/03/02
- [PATCH v8 03/23] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge, Bernhard Beschow, 2023/03/02
- [PATCH v8 05/23] hw/isa/piix3: Create power management controller in host device, Bernhard Beschow, 2023/03/02
- [PATCH v8 06/23] hw/isa/piix3: Move ISA bus IRQ assignments into host device, Bernhard Beschow, 2023/03/02
- [PATCH v8 07/23] hw/isa/piix3: Create IDE controller in host device, Bernhard Beschow, 2023/03/02
- [PATCH v8 08/23] hw/isa/piix3: Wire up ACPI interrupt internally, Bernhard Beschow, 2023/03/02
- [PATCH v8 09/23] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS, Bernhard Beschow, 2023/03/02
- [PATCH v8 11/23] hw/isa/piix3: Rename piix3_reset() for sharing with PIIX4, Bernhard Beschow, 2023/03/02
- [PATCH v8 12/23] hw/isa/piix3: Drop the "3" from PIIX base class, Bernhard Beschow, 2023/03/02
- [PATCH v8 10/23] hw/isa/piix3: Rename pci_piix3_props for sharing with PIIX4, Bernhard Beschow, 2023/03/02
- [PATCH v8 14/23] hw/isa/piix4: Remove unused inbound ISA interrupt lines,
Bernhard Beschow <=
- [PATCH v8 16/23] hw/isa/piix4: Create the "intr" property during init() already, Bernhard Beschow, 2023/03/02
- [PATCH v8 17/23] hw/isa/piix4: Rename reset control operations to match PIIX3, Bernhard Beschow, 2023/03/02
- [PATCH v8 13/23] hw/isa/piix4: Make PIIX4's ACPI and USB functions optional, Bernhard Beschow, 2023/03/02
- [PATCH v8 15/23] hw/isa/piix4: Reuse struct PIIXState from PIIX3, Bernhard Beschow, 2023/03/02
- [PATCH v8 19/23] hw/isa/piix: Harmonize names of reset control memory regions, Bernhard Beschow, 2023/03/02
- [PATCH v8 18/23] hw/isa/piix3: Merge hw/isa/piix4.c, Bernhard Beschow, 2023/03/02
- [PATCH v8 21/23] hw/isa/piix: Consolidate IRQ triggering, Bernhard Beschow, 2023/03/02
- [PATCH v8 20/23] hw/isa/piix: Rename functions to be shared for interrupt triggering, Bernhard Beschow, 2023/03/02
- [PATCH v8 22/23] hw/isa/piix: Share PIIX3's base class with PIIX4, Bernhard Beschow, 2023/03/02
- [PATCH v8 23/23] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4, Bernhard Beschow, 2023/03/02