Re: [PATCH v1 3/3] virtio-pci: defer to commit kvm irq routing when enable msi/msix

[Daniel P . Berrangé]

On Tue, Feb 28, 2023 at 07:29:42AM -0500, Michael S. Tsirkin wrote:
> On Tue, Feb 28, 2023 at 11:07:21AM +0000, Daniel P. Berrangé wrote:
> > IMHO it is not appropriate to criticize the writing of people
> > who may not have English as a first language. 
> 
> Sorry if I offended anyone. I do want change log messages to be clear
> and unambigous though since they are a permanent record. Me rewriting
> them for contributors does not seem to scale. I was hoping a grammar
> checker will help but if not I don't know what to suggest then.

Agreed that having the maintainer frequently rewriting them isn't
scalable in general, but that's not the common case I think/hope.

If a commit message truely isn't easy enough to understand, it is
reasonable to ask the contributor to clarify it and post a v2,
giving them some hints where appropriate.

If it is just sub-optimal grammar that doesn't massively impact
understanding, then I'm inclined to just accept patches as is,
or do very minor copy editting for obvious / simple issues.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|