qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/7] Pegasos2 fixes and audio output support


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 0/7] Pegasos2 fixes and audio output support
Date: Mon, 27 Feb 2023 23:12:46 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 27/2/23 18:47, BALATON Zoltan wrote:
On Mon, 27 Feb 2023, Bernhard Beschow wrote:
Unfortunately my patches had changes merged in. This now makes it hard to
show what really changed (spoiler: nothing that affects behavior).

As you probably noticed in the "resend" version of this iteration I split
off a patch introducing the priq properties. It belongs to the sub series
of the Pegasos2 IRQ fixes which appear unnecessary to me, so I don't want
to show up in `git blame` as the author of any of these changes. I
attributed it to you because this was really your change which I'm not even
sure is legal.

Let's avoid such complications by keeping our series separate.

Let's cool down a bit. Philippe took some of the sm501 patches in his giant pull request (and a lot of your patches too) now so I'll wait until that lands and hope to get some review for the remaining patches too. Once that pull req is merged I'll rebase the remaining patches and resubmit the series also adding changes for reasonable review comments I get by then.

I'm sorry it took me so long, I was expecting these patches to be picked
up by other maintainers but everybody is very busy. I know you'll need
to rebase and it might be painful. But I did that believing it is the
best I could give to the project with my current capacity. Also I don't
want to overlap (too much) into other (sub)maintained areas.
If you are stuck with a rebase, I can try to help.
We'll get to the end of PIIX, if this isn't this release, it will be
the next one. I've been waiting for these cleanups since 4 years
already, before Hervé Poussineau pushed toward that direction during
3 years. We always hit problems due to PC world inheritance which,
as a production system, can not regress.

Also I don't want to compete with you guys, I'd really love to work
together as team, but I have other responsibilities and sometime I
can't spend the time I'd like here.

What blocks the PIIX changes is the "q35/ich9/-device piix3" broken
config. I'll explain elsewhere why it is broken. The problem is I
don't know how to suggest alternative.

Bernhard sometimes it is easier to share visions in a 30min call,
rather than on a such thread. If you want I'm open for one.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]