Re: [PATCH 1/2] hw/vfio/migration: Remove unused 'exec/ram_addr.h' header

[Alex Williamson]

On Mon, 27 Feb 2023 16:24:16 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:

> Alex Williamson <alex.williamson@redhat.com> writes:
> 
> > On Mon, 27 Feb 2023 11:32:57 +0100
> > Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> >  
> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>  
> >
> > Empty commit logs are a pet peeve of mine, there must be some sort of
> > motivation for the change, something that changed to make this
> > possible, or perhaps why this was never necessary.  Thanks,  
> 
> I think that is a little unfair for this case as the motivation and
> action are all covered by the summary line. Granted the overall goal is
> covered by the cover letter and the following patch however for this
> patch I would hope its self explanatory.

The commit title only conveys that the include is unused and the action
to therefore remove it.  The motivation is actually to create target
independent objects and the specific reasoning here is that not only is
this include file unnecessary, but forces per target builds.

This is exactly the "barrier to entry" I mention to Peter, it's obvious
to the experts in the crowd, but it provides no underlying direction
for those who might be more novice.  There is always some reasoning
that can be included in a commit log beyond the simple "a therefore b"
of the commit title.  Thanks,

Alex