[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] hw/vfio/migration: Remove unused 'exec/ram_addr.h' heade
From: |
Alex Bennée |
Subject: |
Re: [PATCH 1/2] hw/vfio/migration: Remove unused 'exec/ram_addr.h' header |
Date: |
Mon, 27 Feb 2023 16:24:16 +0000 |
User-agent: |
mu4e 1.9.21; emacs 29.0.60 |
Alex Williamson <alex.williamson@redhat.com> writes:
> On Mon, 27 Feb 2023 11:32:57 +0100
> Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Empty commit logs are a pet peeve of mine, there must be some sort of
> motivation for the change, something that changed to make this
> possible, or perhaps why this was never necessary. Thanks,
I think that is a little unfair for this case as the motivation and
action are all covered by the summary line. Granted the overall goal is
covered by the cover letter and the following patch however for this
patch I would hope its self explanatory.
Anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
[PATCH 2/2] hw/vfio: Build various target-independent objects once, Philippe Mathieu-Daudé, 2023/02/27