Re: [PATCH v5 3/3] qtests/arm: add some mte tests

[Cornelia Huck]

On Fri, Feb 10 2023, Cornelia Huck <cohuck@redhat.com> wrote:

> On Mon, Feb 06 2023, Eric Auger <eauger@redhat.com> wrote:
>
>> Hi,
>>
>> On 2/3/23 14:44, Cornelia Huck wrote:
>>> +static void mte_tests_default(QTestState *qts, const char *cpu_type)
>>> +{
>>> +    assert_has_feature(qts, cpu_type, "mte");
>>> +
>>> +    /*
>>> +     * Without tag memory, mte will be off under tcg.
>>> +     * Explicitly enabling it yields an error.
>>> +     */
>>> +    assert_set_feature_str(qts, "max", "mte", "off", "{ 'mte': 'off' }");
>>> +    assert_error(qts, cpu_type, "mte=on requires tag memory",
>>> +                 "{ 'mte': 'on' }");
>> Sorry in v4 I reported I preferred the pauth msg, clarifying now:
>>
>>     assert_error(qts, cpu_type, "cannot enable pauth-impdef without pauth",
>>                  "{ 'pauth': false, 'pauth-impdef': true }");
>>
>> Here would translate into cannot enable mte without tag memory.
>
> Oh, so you mean that I should adapt the message generated by the code?

Friendly ping :) Did you mean to adapt the error messages in cpu64.c?