[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_o
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members() |
|
Date: |
Mon, 27 Feb 2023 14:14:53 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> When iterating over a QAPISchemaEnumType, all possible
> values are covered. The 'default' switch case is unreachable,
> remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> scripts/qapi/visit.py | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
> index 26a584ee4c..f66a31a963 100644
> --- a/scripts/qapi/visit.py
> +++ b/scripts/qapi/visit.py
> @@ -159,8 +159,6 @@ def gen_visit_object_members(name: str,
>
> ret += var.ifcond.gen_endif()
> ret += mcgen('''
> - default:
> - abort();
> }
> ''')
This results in a bunch of warnings like
warning: enumeration value ‘FOO__MAX’ not handled in switch [-Wswitch]
Obvious fix: squash into the next patch.