Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_o

From:	Juan Quintela
Subject:	Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members()
Date:	Mon, 27 Feb 2023 13:40:59 +0100
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> When iterating over a QAPISchemaEnumType, all possible
> values are covered. The 'default' switch case is unreachable,
> remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Althought my qapi is rusty.

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/2] qapi: Simplify enum generation, Philippe Mathieu-Daudé, 2023/02/24
- [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members(), Philippe Mathieu-Daudé, 2023/02/24
  - Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members(), Juan Quintela <=
  - Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members(), Markus Armbruster, 2023/02/27
- [PATCH 2/2] qapi: Generate enum count as definition in gen_enum_lookup(), Philippe Mathieu-Daudé, 2023/02/24
  - Re: [PATCH 2/2] qapi: Generate enum count as definition in gen_enum_lookup(), Richard Henderson, 2023/02/24
  - Re: [PATCH 2/2] qapi: Generate enum count as definition in gen_enum_lookup(), Juan Quintela, 2023/02/27
  - Re: [PATCH 2/2] qapi: Generate enum count as definition in gen_enum_lookup(), Markus Armbruster, 2023/02/27

Prev by Date: Re: [PATCH v4 00/15] Dynamically switch to vhost shadow virtqueues at vdpa net migration
Next by Date: Re: [PATCH 2/2] qapi: Generate enum count as definition in gen_enum_lookup()
Previous by thread: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members()
Next by thread: Re: [PATCH 1/2] qapi: Do not generate default switch case in gen_visit_object_members()
Index(es):
- Date
- Thread